Fix an issue in overlay network peer EP list maintenance#721
Merged
aboch merged 1 commit intomoby:masterfrom Oct 29, 2015
Merged
Fix an issue in overlay network peer EP list maintenance#721aboch merged 1 commit intomoby:masterfrom
aboch merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Santhosh Manohar <santhosh@docker.com>
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
aboch
added a commit
that referenced
this pull request
Oct 29, 2015
Fix an issue in overlay network peer EP list maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes moby/moby#17465
For overlay networks every node maintains a list of remote Endpoints (that are present on peer nodes). When one of those remote EPs go down the list wasn't getting deleted. On a container restart on one of the peers EP ID changes, but the name remains the same. So the extra entries in the list can lead to unintended delete of the service records, thus causing the issue reported in docker #17465
Signed-off-by: Santhosh Manohar santhosh@docker.com