Fixes a case of ungraceful daemon restart + unreachable store#724
Merged
mrjana merged 1 commit intomoby:masterfrom Oct 30, 2015
Merged
Fixes a case of ungraceful daemon restart + unreachable store#724mrjana merged 1 commit intomoby:masterfrom
mrjana merged 1 commit intomoby:masterfrom
Conversation
For ungraceful daemon restarts, libnetwork has sandbox cleanup logic to remove any stale & dangling resources. But, if the store is down during the daemon restart, then the cleanup logic would not be able to perform complete cleanup. During such cases, the sandbox has been removed. With this fix, we retain the sandbox if the store is down and the endpoint couldnt be cleaned. When the container is later restarted in docker daemon, we will perform a sandbox cleanup and that will complete the cleanup round. Signed-off-by: Madhu Venugopal <madhu@docker.com>
Contributor
Author
|
this PR + a small patch in docker/docker.will fix moby/moby#17413 |
|
Nice! LGTM |
Contributor
|
LGTM |
mrjana
added a commit
that referenced
this pull request
Oct 30, 2015
Fixes a case of ungraceful daemon restart + unreachable store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For ungraceful daemon restarts, libnetwork has sandbox cleanup logic to
remove any stale & dangling resources. But, if the store is down during
the daemon restart, then the cleanup logic would not be able to perform
complete cleanup. During such cases, the sandbox has been removed. With
this fix, we retain the sandbox if the store is down and the endpoint
couldnt be cleaned. When the container is later restarted in docker
daemon, we will perform a sandbox cleanup and that will complete the
cleanup round.
Signed-off-by: Madhu Venugopal madhu@docker.com