Retain sandbox only if network is not available#732
Merged
mavenugo merged 1 commit intomoby:masterfrom Nov 3, 2015
Merged
Conversation
It is sufficient to check only if network is available in store to make the decision of whether to retain the stale sandbox. If the endpoints are not available then there is no point in retaining the sandbox anyways. This fixes some extreme corner cases, where daemon goes down right in the middle of sandbox cleanup happening. Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
Contributor
|
👍 LGTM |
mavenugo
added a commit
that referenced
this pull request
Nov 3, 2015
Retain sandbox only if network is not available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is sufficient to check only if network is available
in store to make the decision of whether to retain the
stale sandbox. If the endpoints are not available then
there is no point in retaining the sandbox anyways. This
fixes some extreme corner cases, where daemon goes down
right in the middle of sandbox cleanup happening.
Signed-off-by: Jana Radhakrishnan mrjana@docker.com