Libnetwork to program container interface's MAC#803
Libnetwork to program container interface's MAC#803mavenugo merged 1 commit intomoby:masterfrom aboch:pm
Conversation
- Consistently with what it does for IP addresses, libnetwork will also program the container interface's MAC address with the value set by network driver in InterfaceInfo. Signed-off-by: Alessandro Boch <aboch@docker.com>
aboch
changed the title
There was a problem hiding this comment.
I guess this function should be added to other platforms ?
There was a problem hiding this comment.
My understanding is that so far only the osl functions which get invoked from libnetwork are ported to the respective platform package, as this is needed to allow building libnetwork on the other platforms.
This function is not being called outside of the osl package.
There was a problem hiding this comment.
Yes only osl.Sandbox interface methods need to be implemented or stubbed for other platforms. Other platforms may not even have a nwIface
There was a problem hiding this comment.
It is not just this function. but we need to stub a bunch of other existing interface methods that are not implemented.
We can handle it in another PR.
|
LGTM. |
Libnetwork to program container interface's MAC
3 participants
will also program the container interface's MAC address with
the value set by network driver in InterfaceInfo.
Signed-off-by: Alessandro Boch aboch@docker.com