Cleanup stale overlay sandboxes#901
Merged
mavenugo merged 1 commit intomoby:masterfrom Jan 26, 2016
Merged
Conversation
Contributor
There was a problem hiding this comment.
Given you are already using one Sprintf, why not using it for inserting the network id into the string ? This way you avoid another string buffer operation.
path := osl.GenerateKey(fmt.Sprintf("%d-%s", i, n.id))
Contributor
|
LGTM |
Contributor
There was a problem hiding this comment.
I think it would be better if we check for the full network ID contains the full filename (after the marker).
That will take care of also the insanely high epoch number.
When the daemon is ungracefully shutdown, sometimes when we try to create the overlay sandbox after coming back up might get created in a different epoch count which will result in the vxlan interface not properly cleaned up. Fix this by explicitly cleaning up all the previous epoch sandboxes. Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
Contributor
|
LGTM. |
mavenugo
added a commit
that referenced
this pull request
Jan 26, 2016
Cleanup stale overlay sandboxes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the daemon is ungracefully shutdown, sometimes
when we try to create the overlay sandbox after coming
back up might get created in a different epoch count
which will result in the vxlan interface not properly
cleaned up. Fix this by explicitly cleaning up all the
previous epoch sandboxes.
Signed-off-by: Jana Radhakrishnan mrjana@docker.com