Conversation
austinvazquez
force-pushed
the
jumpstart-repo
branch
3 times, most recently
from
70f2705 to
41319c0
Compare
|
Fork PR which ran the GitHub Actions checks since this is the first PR. |
| test: CMD=go test -v ./... | ||
| test: foreach | ||
|
|
||
| .PHONY: help |
There was a problem hiding this comment.
We should also have a look at a step to run and to validate go generate for the seccomp default.json to make sure it matches the code.
We may have something in moby that did this, but probably wouldn't be too complicated.
There was a problem hiding this comment.
Did a quick copy/paste to test this. I gutted most of what we had in moby; it's small enough now should I go through the work to preserve history. Thoughts?
|
|
||
| ## License | ||
|
|
||
| This project is licensed under the Apache License 2.0. See [LICENSE](LICENSE) for details. |
There was a problem hiding this comment.
We still need to add proper license headers to our code (also other projects); I like the approach some projects took with just the SPDX headers and a 1-line copyright (can be multiple), but I need to dig up some research I did on correctness; https://github.com/google/oss-rebuild/blob/6f57c474a8faf3012204792af8ef5d8b6fae2fd1/cmd/proxy/main.go#L2
There was a problem hiding this comment.
Taking a look at this more. The spdx header seems straightforward. The question I have is how much of the copyright/notice needs to be preserved from moby/moby versus can I apply a Moby project authors copyright on top?
austinvazquez
force-pushed
the
jumpstart-repo
branch
5 times, most recently
from
65052cf to
8fb220c
Compare
| - name: Install ltag | ||
| run: go install github.com/containerd/ltag@latest | ||
|
|
||
| - name: Run file header checks | ||
| run: ltag --check -t "./script/validate/template" -v |
There was a problem hiding this comment.
Reused the mechanism I've used in containerd and other projects for file header checks unless there is a more preferred option?
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
jumpstart-repo
branch
5 times, most recently
from
3ae2fb3 to
fd455f8
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
jumpstart-repo
branch
from
fd455f8 to
484a9da
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
thaJeztah
force-pushed
the
jumpstart-repo
branch
from
484a9da to
a1971f1
Compare
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
jumpstart-repo
branch
from
a1971f1 to
8cb655d
Compare
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
made some minor tweaks and fixed some linting
LGTM
go.work.example
Outdated
| go 1.23.0 | ||
|
|
||
| use ( | ||
| ./apparmor | ||
| ./seccomp | ||
| ) |
There was a problem hiding this comment.
We can probably skip this example file for now (to slightly reduce boilerplating in the repo)
Makefile
Outdated
| help: | ||
| @echo "Available targets:" | ||
| @echo " crossbuild - Cross build all modules" | ||
| @echo " test - Run tests for all modules" | ||
| @echo " validate-codegen - Validate code generation for seccomp" | ||
| @echo " help - Display this help message" |
There was a problem hiding this comment.
We can probably use the same implementation as in moby, which uses comments in the Makefile to print help; that way there's less risk for the help to get out of sync with the actual targets; https://github.com/moby/moby/blob/1f71f2217d2196239ca52685ce6b3c4f93a1cc07/Makefile#L184-L186
|
|
||
| ## Security | ||
|
|
||
| For security issues, please follow the [Moby security policy](https://github.com/moby/moby/security/policy). |
There was a problem hiding this comment.
Perhaps we should add a copy in this repo itself as well; we could put it inside /.github/ to reduce clutter at the root.
2 participants
Build out some of the repository boilerplate. e.g. README, gitignore, basic GitHub Actions, etc.