Skip to content

Comments

Remove inSlice in favor of slices.Contains#7

Merged
thaJeztah merged 1 commit intomoby:mainfrom
vvoland:slices-contains
Feb 9, 2026
Merged

Remove inSlice in favor of slices.Contains#7
thaJeztah merged 1 commit intomoby:mainfrom
vvoland:slices-contains

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Dec 16, 2025

No description provided.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines -124 to +114
if inSlice(call.Excludes.Arches, arch) {
if slices.Contains(call.Excludes.Arches, arch) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double checked; looks like were at go1.23 as minimum, so should indeed be supported;

go 1.23.0

@thaJeztah thaJeztah merged commit 9fb5163 into moby:main Feb 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants