Skip to content

Comments

bugfix: make test case right#73

Merged
dmcgowan merged 1 commit intomoby:masterfrom
fuweid:fix_issue72
Oct 23, 2018
Merged

bugfix: make test case right#73
dmcgowan merged 1 commit intomoby:masterfrom
fuweid:fix_issue72

Conversation

@fuweid
Copy link
Contributor

@fuweid fuweid commented Oct 22, 2018

  1. fix format issue for go1.10 --> fix Go 1.10: spdy_bench_test.go:63: Fatalf format %s reads arg #1, but call has only 0 args #72
  2. update the github.com/docker/spdystream/... package test case --> fix ./ws_test.go:27:15: too many arguments in call to conn.Serve #71

Signed-off-by: Wei Fu fuweid89@gmail.com

1. fix format issue for go1.10
2. update the github.com/docker/spdystream/... package test case

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@fuweid
Copy link
Contributor Author

fuweid commented Oct 22, 2018

@dmcgowan could we add the CI for this repo, like travis-CI? This repo is pretty cool but it needs tool for review. How do you think about this? 😄

@dmcgowan
Copy link
Member

LGTM

@dmcgowan dmcgowan merged commit 6480d4a into moby:master Oct 23, 2018
@nim-nim
Copy link

nim-nim commented Oct 23, 2018

Thanks for the fix!

@fuweid fuweid deleted the fix_issue72 branch October 24, 2018 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go 1.10: spdy_bench_test.go:63: Fatalf format %s reads arg #1, but call has only 0 args ./ws_test.go:27:15: too many arguments in call to conn.Serve

3 participants