Skip to content

[manager/dispatcher] Synchronize Dispatcher.Stop() with incoming rpcs.#2498

Merged
thaJeztah merged 1 commit intomoby:bump_v17.06from
anshulpundir:backport
Feb 3, 2018
Merged

[manager/dispatcher] Synchronize Dispatcher.Stop() with incoming rpcs.#2498
thaJeztah merged 1 commit intomoby:bump_v17.06from
anshulpundir:backport

Conversation

@anshulpundir
Copy link
Copy Markdown
Contributor

@anshulpundir anshulpundir commented Feb 1, 2018

git cherry-pick 0b2778a
Cherry pick was clean, with negligible conflict resolution

Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
@anshulpundir
Copy link
Copy Markdown
Contributor Author

@andrewhsu We spoke about this two days ago. This is for LMK when you want us to merge this.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 2, 2018

Codecov Report

Merging #2498 into bump_v17.06 will decrease coverage by 3.7%.
The diff coverage is 85.71%.

@@              Coverage Diff               @@
##           bump_v17.06   #2498      +/-   ##
==============================================
- Coverage         64.5%   60.8%   -3.71%     
==============================================
  Files               59     120      +61     
  Lines             8762   20001   +11239     
==============================================
+ Hits              5652   12161    +6509     
- Misses            2534    6499    +3965     
- Partials           576    1341     +765

Copy link
Copy Markdown

@fcrisciani fcrisciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

Linking the original PR for discoverability; #2495

Copy link
Copy Markdown
Contributor

@stevvooe stevvooe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

thanks! I’ll merge so that we can bump

@thaJeztah thaJeztah merged commit 3d6e1d4 into moby:bump_v17.06 Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants