manager: restore NewServer to v2 signature#3212
Merged
dperny merged 1 commit intomoby:masterfrom Aug 26, 2025
Merged
Conversation
dperny
approved these changes
Aug 26, 2025
While NewServer is probably not called by any code outside the swarmkit module, we should still be good maintainers by taking reasonable measures to avoid introducing breaking changes to the module. Instead provide a view-response mutator to controlapi by setting an exported struct field on the constructed Server. Since for similar compatibility reasons we can't ever add new methods to the view-response interface, rename it to better reflect its narrow scope. Signed-off-by: Cory Snider <csnider@mirantis.com>
corhere
force-pushed
the
controlapi-hooks-nonbreaking-change
branch
from
b84e7be to
58e37b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Undid the breaking change introduced by the previous PR without loss of functionality.
- How I did it
While NewServer is probably not called by any code outside the swarmkit module, we should still be good maintainers by taking reasonable measures to avoid introducing breaking changes to the module. Instead provide a view-response mutator to controlapi by setting an exported struct field on the constructed Server.
Since for similar compatibility reasons we can't ever add new methods to the view-response interface, rename it to better reflect its narrow scope.
- How to test it
- Description for the changelog