reexec: touch-up docs and add some example uses#206
Conversation
thaJeztah
force-pushed
the
reexec_docs
branch
3 times, most recently
from
3c28d03 to
ed57227
Compare
| // fork-without-exec in Go, since the runtime is not fork-safe once multiple | ||
| // threads exist (see [os.StartProcess] and https://go.dev/issue/27505). | ||
| // | ||
| // Example (multi-call binary): |
There was a problem hiding this comment.
nit: I would move example to a separate file, example_test.go or so. Having example in comments means that it is never even compiled, which will make it outdated.
Go examples are at least compiled.
There was a problem hiding this comment.
Yeah; I did that for the other one; but was looking for a "here's how it would be used for multi-call binary", and of course the symlinks aren't really something to do in an example test.
There was a problem hiding this comment.
and of course the symlinks aren't really something to do in an example test.
I think it can still be done, you just create the binary first using go test -c and then go create symlinks. I haven't tested this, but in case your example has // Output: line at the end of the function, it will actually be run during tests (to check the output matches).
I agree it can be cumbersome though, so if you want it to leave as it, I'm fine with it.
There was a problem hiding this comment.
Yeah, it's possible to test probably, but I don't think that works for pkg.go.dev to do something similar to that 🤔
I think this one is fine to keep; I'm adding a second "mocked" example for this scenario in #208
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
3 participants
No description provided.