mountinfo.GetMountsFromReader() use strings.SplitN()#76
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Aug 23, 2021
Merged
mountinfo.GetMountsFromReader() use strings.SplitN()#76AkihiroSuda merged 1 commit intomoby:masterfrom
AkihiroSuda merged 1 commit intomoby:masterfrom
Conversation
We expect 2 fields to be there, anything below (or above) will produce an error, so limit the number of strings we split into to 3. This still allows us to detect "too many colons", but won't result in splitting without bounds. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
@AkihiroSuda ptal |
AkihiroSuda
approved these changes
Aug 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We expect 2 fields to be there, anything below (or above) will produce
an error, so limit the number of strings we split into to 3. This still
allows us to detect "too many colons", but won't result in splitting
without bounds.