Skip to content

🐛 bug: fix types #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mococa merged 2 commits into from
Jul 7, 2023
Merged

🐛 bug: fix types #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
223f890
:bug: bug: fix types
mococa Jul 7, 2023
c95fb76
fix code organisation
mococa Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions infrastructure/lib/null-stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,13 @@ import * as lambda from "aws-cdk-lib/aws-lambda";
import * as apigateway from "aws-cdk-lib/aws-apigatewayv2";
import { Construct } from "constructs";

/* ---------- Types ---------- */
import { NullStackCDK } from "./@types";

/* ---------- Interfaces ---------- */
interface GetBucket extends s3.BucketProps {
bucket_name: string;
resource_name: string;
environment: string;
}

interface Bucket {
/**
* Bucket resource ID
Expand All @@ -26,6 +29,7 @@ interface Bucket {
name: string;
}

/* ---------- Types ---------- */
type SSG = {
build_type: "ssg";

Expand Down Expand Up @@ -108,7 +112,7 @@ export class NullstackAppStack extends cdk.Stack {
resource_name,
environment,
...props
}: NullStackCDK.GetBucket): s3.IBucket {
}: GetBucket): s3.IBucket {
return new s3.Bucket(this, `${resource_name}-${environment}`, {
bucketName: `${bucket_name}-${environment}`,
removalPolicy: cdk.RemovalPolicy.DESTROY,
Expand Down