Fix: Azure Prod Deploy by moconnell · Pull Request #97 · moconnell/yolo

moconnell · 2026-02-10T08:41:53Z

Summary by CodeRabbit

Bug Fixes
- Corrected Key Vault URI construction for proper secret access.
Chores
- Made build/deploy use configurable project and publish output; improved publish verification and packaging.
- Ensured appsettings publish behavior is handled correctly.
- Added Application Insights dependency and ignored generated publish/output folders.
- Refined CI workflow triggers for push and pull request handling.

coderabbitai · 2026-02-10T08:42:08Z

Warning

Rate limit exceeded

@moconnell has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 57 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

Parameterizes the Azure Functions deploy workflow with FUNCTION_PROJECT and PUBLISH_DIR, adds publish-output verification steps, updates publish/copy settings for appsettings, adds ignore patterns, adds Microsoft.ApplicationInsights package entry, and fixes Key Vault URI formation in the Bicep template.

Changes

Cohort / File(s)	Summary
Deployment Workflow `.github/workflows/deploy-azure-functions.yml`	Add `FUNCTION_PROJECT` and `PUBLISH_DIR`; use them for restore/build/publish; verify publish output (list files, require `host.json` and at least one binary, optionally report `functions.metadata`/`worker.config.json`); deploy package from `PUBLISH_DIR`; apply verifications on production/pr path.
CI Trigger `.github/workflows/dotnet.yml`	Change workflow triggers to explicitly include `push` on `master`/`develop` and add a `pull_request` trigger.
Ignore Patterns `/.gitignore`	Add `[Oo]utput/` and `[Pp]ublish/` to ignore generated build/publish folders.
Project Publish Settings `src/YoloFunk/YoloFunk.csproj`	Set `appsettings.json` to `CopyToPublishDirectory="Always"`; change environment appsettings entry to `Update="appsettings.*.json"` with `CopyToPublishDirectory="Never"`; keep `local.settings.json` behavior unchanged.
Packages `Directory.Packages.props`	Add `PackageVersion Include="Microsoft.ApplicationInsights" Version="2.23.0"`; reformat some package entries to multiline (no other version changes).
Infrastructure (Bicep) `.azure/function-app.bicep`	When `keyVaultName` is provided, change Key Vault URI construction from `https://${keyVaultName}.${environment().suffixes.keyvaultDns}` to `https://${keyVaultName}${environment().suffixes.keyvaultDns}` for secret URIs.

Sequence Diagram(s)

sequenceDiagram
    participant GH as "GitHub Actions"
    participant Runner as "Runner (dotnet SDK)"
    participant FS as "Publish Dir (artifact)"
    participant Azure as "Azure Functions Deploy"

    GH->>Runner: checkout + set env (FUNCTION_PROJECT, PUBLISH_DIR)
    Runner->>Runner: dotnet restore/build/publish for FUNCTION_PROJECT
    Runner->>FS: write publish output to PUBLISH_DIR
    Runner->>FS: verify publish (list files, check host.json, check binaries)
    alt verification passes
        Runner->>Azure: package & deploy from PUBLISH_DIR
        Azure-->>Runner: deployment result
    else verification fails
        Runner-->>GH: fail job with verification logs
    end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

chore: upgrade packages #30 — touches Directory.Packages.props; likely related to package-version additions/formatting.
Remove: Dead Projects #46 — modifies src/YoloFunk project files; related to publish/csproj changes.

Poem

🐰 I hopped through workflows bright and keen,

I set the project path and checked the scene,
host.json snug, binaries in tow,
Vault URL fixed — off we go,
A tiny hop toward Azure's green.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix: Azure Prod Deploy' directly and clearly relates to the main changes, which focus on fixing the Azure Functions deployment workflow and associated configurations.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/azure-prod-deploy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-02-10T08:50:40Z