Add experimental option to sandbox create #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
commented
Dec 4, 2025
modal-go/test/sandbox_test.go
Outdated
Comment on lines
768
to
769
| func TestSandboxExperimentalDockerMock(t *testing.T) { | ||
| t.Skip("Unable to mock out SandboxGetLogs") |
Contributor
Author
There was a problem hiding this comment.
@ehdr Do you think it's useful to have a skipped mock test given that we can not mock out SandboxGetLogs yet?
ehdr
approved these changes
Dec 8, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
thomasjpfan
force-pushed
the
thomasjpfan/expermental_options
branch
from
e029bbd to
b53fb57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
experimental_optionsto Sandbox.Create in the JS and Go SDKs.Note
Adds experimentalOptions to Sandbox.create in JS and Go, validates boolean flags, forwards them to the proto, and tests the
enable_dockeroption.experimentalOptions(Record<string, any>in JS,map[string]anyin Go) toSandbox.create/Sandbox.Createparams.experimentalOptions(Record<string, boolean>/map[string]bool).SandboxCreateRequest.definition.experimentalOptions.experimentalOptions.enable_dockerpresence (checks/var/lib/docker).experimentalOptions.enable_dockerfor Sandbox creation in JS/Go.Written by Cursor Bugbot for commit b53fb57. This will update automatically on new commits. Configure here.