Skip to content

Add developer observability tools, fix trigger visualiser rendering, fix text overlap#100

Merged
modawan merged 1 commit intomodawan:masterfrom
Eldbury:clean-pr-dev-tools
Apr 25, 2026
Merged

Add developer observability tools, fix trigger visualiser rendering, fix text overlap#100
modawan merged 1 commit intomodawan:masterfrom
Eldbury:clean-pr-dev-tools

Conversation

@Eldbury
Copy link
Copy Markdown

@Eldbury Eldbury commented Apr 24, 2026

Summary

This PR contains the developer-observability work split out from the earlier mixed branch.

Included:

  • developer observability overlay / watch panel / hotkey help
  • trigger visualisation rendered through the main scene pipeline
  • fix for the trigger visualiser projection/distortion issue
  • short/long actor labels (Ctrl+Shift+A / Ctrl+Shift+L)
  • dyn_cast downcasts in this code path
  • small overlay/watch-panel layout cleanups

Not included:

  • gameplay/runtime dialogue progression fixes
  • trigger delayed-action / action-semantics fixes
  • movie/audio fixes
  • docs/scripts/evals/log junk

Verification

  • manual in-game validation of trigger outlines across camera angles
  • manual validation of short/verbose labels
  • manual validation of overlay/watch panel behaviour
  • local Windows Release build passed
  • local unit tests passed
  • combined smoke-stack test passed

Expected sibling PR overlap

This branch may need a small follow-up rebase if a sibling PR lands first.

Expected overlap is limited to:

  • src/libs/game/object/area.cpp
  • src/libs/game/object/trigger.cpp
  • include/reone/game/game.h
  • src/libs/game/game.cpp

The overlap is expected because the split is by concern rather than by touched file.

This PR contains the developer-observability work split out from the earlier mixed branch.

Included:
- developer observability overlay / watch panel / hotkey help
- trigger visualisation rendered through the main scene pipeline
- fix for the trigger visualiser projection/distortion issue
- short/long actor labels (`Ctrl+Shift+A` / `Ctrl+Shift+L`)
- `dyn_cast` downcasts in this code path
- small overlay/watch-panel layout cleanups
@modawan modawan force-pushed the clean-pr-dev-tools branch from bb69efa to 174b78b Compare April 25, 2026 14:40
Copy link
Copy Markdown
Owner

@modawan modawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The new developer overlay looks good, and very useful!

@modawan modawan merged commit 1ba7fed into modawan:master Apr 25, 2026
2 checks passed
@Eldbury Eldbury deleted the clean-pr-dev-tools branch April 26, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants