Conversation
Gliphs library has 256 glyphs in total. Lower 128 glyphs are ASCII, higher values are for non-ASCII characters. Char type is 8-bit signed, so we need to bitcast it to unsigned to avoid negative indices. The problem was reported and fixed in seedhartha#61.
Owner
Author
|
Hats off to @Lyuu17 for finding the problem and preparing the patch. |
Owner
Author
|
The issue with vertical lines is tracked separately in #25. It is present in English version of the game too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glyphs library has 256 glyphs in total. Lower 128 glyphs are ASCII, higher values are for non-ASCII characters. Char type is 8-bit signed, so we need to bitcast it to unsigned to avoid negative indices.
The problem was reported and fixed in seedhartha#61.