ci: Tweak ci so it doesn't run without meaningful changes #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhusar
requested changes
Jul 3, 2024
Member
rhusar
left a comment
rhusar
left a comment
There was a problem hiding this comment.
So no verifying building docs when Doxyfile is changed? :)
Member
Author
Fixed. |
rhusar
requested changes
Jul 3, 2024
Member
rhusar
left a comment
rhusar
left a comment
There was a problem hiding this comment.
Still not a great approach. Going forward, we would need to keep in mind that adding new paths need to be added for CI scripts.
Rather than selecting which files to run the build for, we can just label the ones that definitely do not effect the build.
Opened #248
Member
|
For example, this would still run tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It occurred to me that we run CI on all commits regardless the changes. This PR will cause CI running only if anything within the CI file, or
native/,test/directories changes.