Skip to content

Conversation

@jajik
Copy link
Member

@jajik jajik commented Jul 4, 2024

followup for #248 and #246

@jajik jajik requested a review from rhusar July 4, 2024 08:46
@jajik jajik force-pushed the ci-workaround-ignored-paths branch from 0debeb4 to 9a3b360 Compare July 4, 2024 08:49
@jajik
Copy link
Member Author

jajik commented Jul 4, 2024

The pipeline will be failing until we merge #250

Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, thanks for the hack demonstration, this would work. But oh man, 50 LOC hack to manage just to solve a non-existent problem is not great use of our time.

Let me try couple of other things, if not, I ll revert the original change.

@jajik jajik force-pushed the ci-workaround-ignored-paths branch from 9a3b360 to 2fff3fb Compare July 4, 2024 12:20
Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try this until GH fixes this (even though it's been long time in the making).

@rhusar rhusar merged commit 94c1953 into modcluster:main Jul 10, 2024
@rhusar
Copy link
Member

rhusar commented Jul 10, 2024

BTW I did toy around with the idea of creating a first step to get list of all changes files, if they match any of these, then skip the following jobs. But that's more error prone than this approach, so I scratched that.

@jajik
Copy link
Member Author

jajik commented Jul 10, 2024

Lets try this until GH fixes this (even though it's been long time in the making).

You mean like this one https://github.com/orgs/community/discussions/12032 ? 😃

@jajik
Copy link
Member Author

jajik commented Jul 10, 2024

Thanks for the merge

@jajik jajik deleted the ci-workaround-ignored-paths branch July 10, 2024 09:22
@rhusar
Copy link
Member

rhusar commented Jul 10, 2024

Lets try this until GH fixes this (even though it's been long time in the making).

You mean like this one https://github.com/orgs/community/discussions/12032 ? 😃

The rebase button is crap - that invalidates signing information. Using a merge commit in turn adds a lot of noise with merge commits. Sigh..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants