-
Notifications
You must be signed in to change notification settings - Fork 16
Ci workaround ignored paths #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0debeb4 to
9a3b360
Compare
|
The pipeline will be failing until we merge #250 |
rhusar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL, thanks for the hack demonstration, this would work. But oh man, 50 LOC hack to manage just to solve a non-existent problem is not great use of our time.
Let me try couple of other things, if not, I ll revert the original change.
9a3b360 to
2fff3fb
Compare
rhusar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets try this until GH fixes this (even though it's been long time in the making).
|
BTW I did toy around with the idea of creating a first step to get list of all changes files, if they match any of these, then skip the following jobs. But that's more error prone than this approach, so I scratched that. |
You mean like this one https://github.com/orgs/community/discussions/12032 ? 😃 |
|
Thanks for the merge |
The rebase button is crap - that invalidates signing information. Using a merge commit in turn adds a lot of noise with merge commits. Sigh.. |
followup for #248 and #246