Skip to content

Conversation

@jajik
Copy link
Member

@jajik jajik commented Oct 31, 2024

There is a typo/error in the error message: for -> before.

@jajik jajik added the bug label Oct 31, 2024
@jajik jajik requested review from jfclere and rhusar October 31, 2024 15:48
@jajik jajik merged commit f6cb55a into modcluster:main Nov 5, 2024
10 checks passed
@jajik
Copy link
Member Author

jajik commented Nov 5, 2024

Thanks for the review

@jajik jajik deleted the typo branch November 5, 2024 10:33
@rhusar
Copy link
Member

rhusar commented Nov 5, 2024

Interestingly enough, the https://docs.modcluster.io/legacy/ mention the old variant but https://docs.modcluster.io/#waitbeforeremove is correct. So perhaps not just a typo but that's what it was called?

@jfclere
Copy link
Member

jfclere commented Nov 6, 2024

@rhusar do you want to support both version? or assume we are good?

@jajik
Copy link
Member Author

jajik commented Nov 6, 2024

I've just quickly scanned the repo (the original one) and it seems the directive was always WaitBeforeRemove (from 1.2.x) and that the docs were simply wrong. At least that's how it looks like.

@rhusar
Copy link
Member

rhusar commented Nov 6, 2024

@rhusar do you want to support both version? or assume we are good?

We are good, so no, we don't need/want to support the wrong version since that has never worked.

@rhusar
Copy link
Member

rhusar commented Nov 6, 2024

I've just quickly scanned the repo (the original one) and it seems the directive was always WaitBeforeRemove (from 1.2.x) and that the docs were simply wrong. At least that's how it looks like.

Did the same search today with same conclusion ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants