Skip to content

Conversation

@jajik
Copy link
Member

@jajik jajik commented Nov 5, 2024

Well, that's not completely true. The default behaviour is '**', the single * does not match branches with / in their name. Fortunately, we are all well behaved and don't use such names. 🙂

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#patterns-to-match-branches-and-tags

@jajik jajik requested a review from rhusar November 6, 2024 14:57
@rhusar
Copy link
Member

rhusar commented Nov 6, 2024

I am kinda surprised this is not required.. (it's kind of silly that this behavior would be implicit). but if that works and you want it, why not.

@rhusar
Copy link
Member

rhusar commented Nov 6, 2024

I guess it's because we added 'paths' since then and you can't have an empty tree in yml.

@rhusar rhusar merged commit 0781362 into modcluster:main Nov 6, 2024
10 checks passed
@jajik jajik deleted the simplify-ci branch November 6, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants