Install updated toolchain to the one from the kani release #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsn
force-pushed
the
install-toolchain
branch
from
6b75397 to
ec2a9cb
Compare
danielsn
force-pushed
the
install-toolchain
branch
from
ec2a9cb to
0c1d3d3
Compare
celinval
reviewed
Oct 28, 2022
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
I am wondering if we can just download the kani toolchain file that specify the toolchain we use to avoid installing 2 different toolchains.
Contributor
Author
|
For now I manually put it in to the script. Making this autopull from the release toolchain would be a nice improvement, I'll file a ticket for that |
Contributor
Author
danielsn
force-pushed
the
install-toolchain
branch
from
aff920b to
a37322a
Compare
celinval
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently, we rely on the default toolchain on the machine. If its too old, that causes problems like here: https://github.com/aws/s2n-quic/actions/runs/3347681915/jobs/5545938616
Resolved issues:
Resolves #ISSUE-NUMBER
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.