Skip to content

Remove mathlib dependency#9

Merged
BrunoDutertre merged 3 commits intomodel-checking:mainfrom
zhassan-aws:no-mathlib-batteries
Aug 13, 2024
Merged

Remove mathlib dependency#9
BrunoDutertre merged 3 commits intomodel-checking:mainfrom
zhassan-aws:no-mathlib-batteries

Conversation

@zhassan-aws
Copy link
Contributor

@zhassan-aws zhassan-aws commented Aug 12, 2024

Remove mathlib from dependencies and fix all proofs.

Call outs: I had to add batteries as a dependency, but all definitions/theorems needed from batteries (e.g. List.IsPrefix) have been upstreamed in https://github.com/leanprover/lean4/releases/tag/v4.11.0-rc1 (e.g. leanprover/lean4#4836), so we should be able to get rid of the batteries dependency as well once v4.11.0 is released.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws requested review from a team and BrunoDutertre as code owners August 12, 2024 20:10
@BrunoDutertre
Copy link
Collaborator

Maybe convert to lakefile.toml instead of lakefile.lean.
This command can do it:

 lake translate-conflig toml

@BrunoDutertre
Copy link
Collaborator

Works for me.

@BrunoDutertre BrunoDutertre merged commit bc90fc7 into model-checking:main Aug 13, 2024
@zhassan-aws zhassan-aws deleted the no-mathlib-batteries branch September 20, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants