Skip example enterely to minimise false positives in template updates#22
Merged
irm-codebase merged 2 commits intomainfrom May 19, 2025
Merged
Skip example enterely to minimise false positives in template updates#22irm-codebase merged 2 commits intomainfrom
irm-codebase merged 2 commits intomainfrom
Conversation
…, except for Snakefile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version of the template does not skip example configuration / schema and similar files.
This can lead to false positives or risk changes to them 'trickling' down to projects.
To avoid this, we generate them once during
copy, and skip them entirely in following updates since they'll be project-exclusive.If a project removes an essential file (like the schema) or brakes naming convention, this should be identified in parsing projects like
clio, not by the template.The one file I left was
Snakefile, to enable us to update things like the minimal compatible version in case of breaking changes on snakemake.