Skip to content

Feature modelblocks#11

Open
irm-codebase wants to merge 8 commits intomainfrom
feature-modelblocks
Open

Feature modelblocks#11
irm-codebase wants to merge 8 commits intomainfrom
feature-modelblocks

Conversation

@irm-codebase
Copy link
Copy Markdown

Fixes #10 and #9

Summary of changes in this pull request

  • Updated to the latest version of the template
  • Added <pathvars> to the module to increase flexibility
  • Pinned numpy to avoid version conflict error

Reviewer checklist

  • There are no pip dependencies in the module's environment files (workflow/envs/).
  • All rules use pathvars (e.g., <results>) in their inputs and outputs.
  • The integration test-suite is successful, including:
    • pre-commit.ci tests pass.
    • tests pass for all relevant OS configurations (linux, osx, windows).
  • Module documentation is up-to-date, including:
    • INTERFACE.yaml mentions all relevant pathvars and wildcards.
    • README.md describes how to use the module and has the necessary citations.

@irm-codebase irm-codebase requested a review from sjpfenninger May 1, 2026 15:37
@irm-codebase
Copy link
Copy Markdown
Author

@sjpfenninger For now I decided to not expose the subunit output files as a pathvar for simplicity.
I figure that these are in reality intermediate files, and that users will generally only want the file with only the {shape} and {tech} wildcards.

@irm-codebase irm-codebase linked an issue May 1, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to modelblocks Pin numpy to avoid typing conflict bug in pandera

1 participant