fix(docs): correct two specReferences[].url strings that 404#314
Open
panyam wants to merge 1 commit into
Open
Conversation
- SEP-986: SEP/SEP-986.md was removed from modelcontextprotocol/modelcontextprotocol when the SEP merged into the spec. Pointing at the SEP discussion thread at issues/986 instead (aligned with how other SEPs in this file link to their issue/PR). - SEP-990 Enterprise-Managed-OAuth: filename mismatch. The actual file in modelcontextprotocol/ext-auth is enterprise-managed-authorization.mdx, not enterprise-oauth.mdx. Verified the new URLs return HTTP 200 with curl. Fixes issue 313.
Author
|
Hey @CaitieM20 - Thought of putting out a small docs fix that came out of the conformance audit work I've been doing. Two URLs in specReferences[] currently 404. #313 has the repro. Can I hassle you for a quick look when you have a moment. Ive been building a way to run/track/prioritize conformance suites on SDKs (starting with my own so these URLs are quite valuble) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Two
specReferences[].urlstrings in the scenario source point at files that return HTTP 404 on github.com. Any downstream audit harness that renders these references to humans hits broken links. Verified withcurl -sIreturning HTTP 404 against both URLs.This PR fixes both URLs to point at canonical, currently-existing locations. Fixes issue 313.
How Has This Been Tested?
Verified each new URL returns HTTP 200 with
curl -sI:No code paths or assertions changed. The strings affected are display-only
specReferences[].urlfields that downstream tooling renders for humans.Breaking Changes
None. The string keys (
idfields) are unchanged; only theurlvalues are corrected. Downstream tools that hardcode any of these URLs would need to update, but the deprecation is implicit because the old URLs already 404.Types of changes
Checklist
Additional context
SEP-986: the original URL pointed at
SEP/SEP-986.mdinmodelcontextprotocol/modelcontextprotocol. That path was removed when the SEP merged into the spec. The new URLhttps://github.com/modelcontextprotocol/modelcontextprotocol/issues/986matches the convention used by other SEPs insrc/scenarios/server/tools.tsandsrc/scenarios/client/auth/spec-references.tswhich link to their SEP issue or PR rather than to a file in the repo tree.SEP-990 Enterprise-Managed-OAuth: a filename mismatch. The source cites
enterprise-oauth.mdx; the actual file isenterprise-managed-authorization.mdx. Confirmed by listingspecification/draft/inmodelcontextprotocol/ext-auth:The "tests pass locally" box is unchecked because no test surface exercises these URL strings; they are emitted in
specReferences[]arrays and consumed by downstream renderers, not by scenario assertions.