Add RegisterTools API to McpClient for pre-populating tool cache#1590
Open
tarekgh wants to merge 3 commits into
Open
Add RegisterTools API to McpClient for pre-populating tool cache#1590tarekgh wants to merge 3 commits into
tarekgh wants to merge 3 commits into
Conversation
This enables MCP clients to send Mcp-Param-* HTTP headers without requiring a prior ListToolsAsync call, addressing issue modelcontextprotocol#1577. Changes: - Add RegisterTools abstract method to McpClient with XML documentation - Implement RegisterTools in McpClientImpl with thread-safe ConcurrentDictionary for registered tool name tracking - Modify ToolCacheClearing to preserve registered tools across ListToolsAsync calls while clearing server-discovered tools - Add fast path optimization when no tools are registered - Validate x-mcp-header annotations on registered tools Tests: - 11 unit tests covering cache interaction scenarios - 3 HTTP integration tests verifying Mcp-Param-* headers are sent without ListToolsAsync
Adding an abstract member to McpClient is a breaking change (CP0005) because existing subclasses would fail to compile. Changed to virtual with a default no-op implementation that validates the argument.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a RegisterTools API to McpClient that allows pre-populating the internal tool cache with tool definitions. This enables MCP clients to send \Mcp-Param-*\ HTTP headers (based on \x-mcp-header\ schema annotations) without requiring a prior \ListToolsAsync\ call.
Fixes #1577
Changes
API Addition
Implementation Details
Cache Interaction Behavior
Tests
Unit Tests (11 tests)
HTTP Integration Tests (3 tests)