Skip to content

Skip flaky test on Mono where stderr callbacks are unsupported #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 20, 2025
Merged

Skip flaky test on Mono where stderr callbacks are unsupported #980

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35df5a1
Initial plan
Copilot Nov 18, 2025
7d83b08
Fix race condition in StdioClientSessionTransport stderr handling
Copilot Nov 18, 2025
4b8a947
Simplify WaitForExit logic as suggested in code review
Copilot Nov 18, 2025
688a602
Skip flaky test on Mono and revert incorrect fix
Copilot Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/ModelContextProtocol.Tests/Transport/StdioClientTransportTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ public async Task CreateAsync_ValidProcessInvalidServer_Throws()
await Assert.ThrowsAsync<IOException>(() => McpClient.CreateAsync(transport, loggerFactory: LoggerFactory, cancellationToken: TestContext.Current.CancellationToken));
}

// [Fact(Skip = "Platform not supported by this test.", SkipUnless = nameof(IsStdErrCallbackSupported))]
[Fact]
[Fact(Skip = "Platform not supported by this test.", SkipUnless = nameof(IsStdErrCallbackSupported))]
public async Task CreateAsync_ValidProcessInvalidServer_StdErrCallbackInvoked()
{
string id = Guid.NewGuid().ToString("N");
Expand Down
Loading