Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

Conversation

@samuel871211
Copy link
Contributor

@samuel871211 samuel871211 commented Mar 20, 2025

The code example use readline

......
import { StdioClientTransport } from "@modelcontextprotocol/sdk/client/stdio.js";
import readline from "readline/promises";
import dotenv from "dotenv";

Based on NodeJS official document

readline requires NodeJS 17 or above

Motivation and Context

Update document

How Has This Been Tested?

Update document only

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

`Node.js 16 or higher installed` => `Node.js 17 or higher installed`
why => `readline` requires NodeJS 17 or above.
`import readline from "readline/promises";`
@samuel871211 samuel871211 changed the title doc: update file quickstart/client.mdx doc: update file quickstart/client.mdx with correct NodeJS version Mar 21, 2025
@dsp-ant dsp-ant self-requested a review March 24, 2025 11:03
Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you

@dsp-ant dsp-ant merged commit c241f8a into modelcontextprotocol:main Mar 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants