chore: drop GitHub issue URLs from pre-handshake guard log messages#625
Merged
chore: drop GitHub issue URLs from pre-handshake guard log messages#625
Conversation
The runtime console.error/warn strings in App._assertInitialized and AppBridge.replaceRequestHandler linked to a tracking issue. Issue URLs in runtime logs are brittle and send developers to a discussion thread rather than actionable docs; the message itself already says what to do. JSDoc @see links retained.
Contributor
PreviewPreview deployments for this PR have been cleaned up. |
@modelcontextprotocol/ext-apps
@modelcontextprotocol/server-basic-preact
@modelcontextprotocol/server-basic-react
@modelcontextprotocol/server-basic-solid
@modelcontextprotocol/server-basic-svelte
@modelcontextprotocol/server-basic-vanillajs
@modelcontextprotocol/server-basic-vue
@modelcontextprotocol/server-budget-allocator
@modelcontextprotocol/server-cohort-heatmap
@modelcontextprotocol/server-customer-segmentation
@modelcontextprotocol/server-debug
@modelcontextprotocol/server-map
@modelcontextprotocol/server-pdf
@modelcontextprotocol/server-scenario-modeler
@modelcontextprotocol/server-shadertoy
@modelcontextprotocol/server-sheet-music
@modelcontextprotocol/server-system-monitor
@modelcontextprotocol/server-threejs
@modelcontextprotocol/server-transcript
@modelcontextprotocol/server-video-resource
@modelcontextprotocol/server-wiki-explorer
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #623. The runtime
console.error/console.warnstrings inApp._assertInitializedand theAppBridge.replaceRequestHandleroverride included a link to a tracking issue. Issue URLs in runtime logs are brittle (issues get closed/locked) and send developers to a discussion thread rather than actionable docs; the message itself already says what to do ("awaitapp.connect(), or move data loading to anontoolresulthandler"). The JSDoc@seelinks on the private members are kept.Test plan
bun test src/app-bridge.test.ts— 94/94 pass (test regex doesn't match the URL).