Adding the same tool results in a jsonschema: Resolve: root already resolved error

[jameslynnwu]

Describe the bug
A clear and concise description of what the bug is.

Adding the same tool results in a jsonschema: Resolve: root already resolved error

Despite the code saying that adding the same tool is a noop.

go-sdk/mcp/server.go

Line 166 in b34ba21

func AddTool[In, Out any](s *Server, t *Tool, h ToolHandlerFor[In, Out]) {

To Reproduce
Steps to reproduce the behavior:

1. Add the same tool twice to the server

Expected behavior
A clear and concise description of what you expected to happen.
No error should occur.

Logs
If applicable, add logs to help explain your problem.

Additional context
Add any other context about the problem here.

[findleyr]

Thanks. This is indeed a bug (and a confusing error message, from jsonschema resolution!)

[KamdynS]

Has anyone claimed this? I can open a PR for a fix I just made locally.

[findleyr]

Thanks, that would be great. I'll review your PR.

[jba]

Your code isn't wrong (although there is an easier way to clone schemas, the CloneSchemas method).
But in this case the fix is simpler and more direct: addToolErr should check the tools featureSet before calling newServerTool, by calling s.tools.get.

[KamdynS]

Oh, sure. Would you prefer a new PR or a new commit on the PR I have open?

[findleyr]

@KamdynS a new commit on this PR is preferred: we'll squash when we merge.

[KamdynS]

Okay I've added a new commit.