mcp: fix setProgressToken when Meta is nil#846
Merged
maciej-kisiel merged 2 commits intomodelcontextprotocol:mainfrom Mar 18, 2026
Merged
mcp: fix setProgressToken when Meta is nil#846maciej-kisiel merged 2 commits intomodelcontextprotocol:mainfrom
maciej-kisiel merged 2 commits intomodelcontextprotocol:mainfrom
Conversation
Contributor
Author
|
Duplicating with existing PR |
Contributor
|
Given that the other PR is not proceeding, we can revive this one. It looks good in its current form. |
maciej-kisiel
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
SetProgressTokenis called on aParamsstruct with a nilMetafield, the newly created map is never assigned back to the struct via
SetMeta, causing the progress token to be silently lost.Call
p.SetMeta(m)after creating the new map so the struct retains thereference.
Fixes #845