Skip to content

internal: remove unused util functions#871

Merged
maciej-kisiel merged 1 commit intomodelcontextprotocol:mainfrom
alexandear-org:chore/remove-unused-util
Mar 31, 2026
Merged

internal: remove unused util functions#871
maciej-kisiel merged 1 commit intomodelcontextprotocol:mainfrom
alexandear-org:chore/remove-unused-util

Conversation

@alexandear
Copy link
Copy Markdown
Contributor

The functions util.Sorted and util.KeySlice are unused.

Copilot AI review requested due to automatic review settings March 31, 2026 13:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes unused internal utility helpers (util.Sorted and util.KeySlice) to simplify the internal/util package and drop now-unneeded imports.

Changes:

  • Deleted util.Sorted iterator helper and its associated dependencies (cmp, iter, slices).
  • Deleted util.KeySlice map-key collection helper.
  • Simplified internal/util/util.go imports to only what’s still required (fmt).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/util/util.go Outdated
@alexandear alexandear force-pushed the chore/remove-unused-util branch from 481420f to 5c7dff2 Compare March 31, 2026 13:16
@alexandear alexandear force-pushed the chore/remove-unused-util branch from 5c7dff2 to f234441 Compare March 31, 2026 13:17
@maciej-kisiel maciej-kisiel merged commit e23b75c into modelcontextprotocol:main Mar 31, 2026
9 checks passed
@alexandear alexandear deleted the chore/remove-unused-util branch March 31, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants