mcp: add optional issuer validator for pre-registered client validation (SEP-2352)#946
Merged
guglielmo-san merged 5 commits intoMay 29, 2026
Merged
Conversation
…inding to a specific authorization server
…e trailing slashes
guglielmo-san
changed the title
| // parameter, which the MCP authorization spec requires to be compared without | ||
| // any normalization. | ||
| func IssuersEqual(a, b string) bool { | ||
| return strings.TrimRight(a, "/") == strings.TrimRight(b, "/") |
Member
There was a problem hiding this comment.
TrimRight will trim all slashes, let's use TrimsSuffix
Contributor
Author
There was a problem hiding this comment.
Ok, also updated the code in auth_meta to follow same logic... it is a behavioral change but it was not yet added to any release
…ash removal and update test infrastructure
yarolegovich
approved these changes
May 29, 2026
guglielmo-san
deleted the
guglielmoc/SEP-2352_authorization_server_binding
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #978