Skip to content

Conversation

@dzhulk
Copy link
Contributor

@dzhulk dzhulk commented Feb 1, 2026

Summary

Fixed circular calls of json validation in ToolsTab. checkValidationErrors() calls validateJson() which calls onChange() which calls checkValidationErrors() again.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Refactoring (no functional changes)
  • Test updates
  • Build/CI improvements

Changes Made

Related Issues

Testing

  • Tested in UI mode
  • Tested in CLI mode
  • Tested with STDIO transport
  • Tested with SSE transport
  • Tested with Streamable HTTP transport
  • Added/updated automated tests
  • Manual testing performed

Test Results and/or Instructions

Screenshots are encouraged to share your testing results for this change.

Checklist

  • Code follows the style guidelines (ran npm run prettier-fix)
  • Self-review completed
  • Code is commented where necessary
  • Documentation updated (README, comments, etc.)

Breaking Changes

Additional Context

@dzhulk
Copy link
Contributor Author

dzhulk commented Feb 1, 2026

proof:
Screenshot_20260201_212839

Copy link
Member

@olaservo olaservo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM - tested with a few tools with JSON form fields as well as simpler inputs.

@olaservo olaservo merged commit 885c8bc into modelcontextprotocol:main Feb 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants