fix McpSchema deserialization issues with Jackson3 while keeping Jackson2 behavior unchanged#979
Open
iuliiasobolevska wants to merge 1 commit into
Open
Conversation
…son2 behavior unchanged modelcontextprotocol#978
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #978
How Has This Been Tested?
Added unit tests utilizing both Jackson2 and Jackson3
Breaking Changes
I spent several cycles trying to find a solution that keeps behavior unchanged when Jackson2 is being used while fixing the deserialization issue for Jackson3:
fromJsonas before@JsonCreator(mode = JsonCreator.Mode.DISABLED)on the canonical constructor, Jackson 3 no longer treats it as a candidate creator. It then falls back to the@JsonCreator-annotated staticfromJsonfactory — the same creator used by Jackson 2. Both mappers now route deserialization throughfromJson.null: still throwsIllegalArgumentExceptionas before (backward compatible).Types of changes
Checklist
Additional context