-
Notifications
You must be signed in to change notification settings - Fork 181
Server feature list changed and resource updated notifications #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28d86b9 to
fde0d7a
Compare
kpavlov
previously approved these changes
Dec 3, 2025
Contributor
kpavlov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @tiginamaria very good PR
I have few comments about logging, but it can be addressed in a separate PR
...rc/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/FeatureNotificationService.kt
Outdated
Show resolved
Hide resolved
...rc/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/FeatureNotificationService.kt
Show resolved
Hide resolved
...rc/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/FeatureNotificationService.kt
Show resolved
Hide resolved
...rc/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/FeatureNotificationService.kt
Outdated
Show resolved
Hide resolved
...rc/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/FeatureNotificationService.kt
Outdated
Show resolved
Hide resolved
...rc/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/FeatureNotificationService.kt
Outdated
Show resolved
Hide resolved
...rc/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/FeatureNotificationService.kt
Outdated
Show resolved
Hide resolved
Fix logging levels Extract send event handling
kpavlov
previously approved these changes
Dec 3, 2025
kpavlov
previously approved these changes
Dec 3, 2025
kpavlov
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Implemented thread-safe notification service following eventual consistency principle.
Fixes #249
Contracts:
The flow of the notification is explained in the diagram:
Documentation references:
https://modelcontextprotocol.io/specification/2025-06-18/server/prompts#list-changed-notification
https://modelcontextprotocol.io/specification/2025-06-18/server/tools#list-changed-notification
https://modelcontextprotocol.io/specification/2025-06-18/server/resources#list-changed-notification
https://modelcontextprotocol.io/specification/2025-06-18/server/resources#subscriptions
Questions:
How Has This Been Tested?
Multiple tests with various notification scenarios were added
Breaking Changes
Types of changes
Checklist
Additional context