Add missing ConfigurationException
#31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
requested review from
CodeWithKyrian,
Nyholm and
chr-hertel
as code owners
OskarStark
force-pushed
the
exception
branch
from
1a67f2b to
2c0c5a1
Compare
OskarStark
commented
Sep 4, 2025
| /** | ||
| * @author Oskar Stark <oskarstark@googlemail.com> | ||
| */ | ||
| class ConfigurationException extends InvalidArgumentException |
Contributor
Author
There was a problem hiding this comment.
Not sure about which class to extend
OskarStark
commented
Sep 4, 2025
OskarStark
commented
Sep 4, 2025
OskarStark
commented
Sep 4, 2025
OskarStark
force-pushed
the
exception
branch
from
d246e45 to
808dbc4
Compare
chr-hertel
requested changes
Sep 4, 2025
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
Wasn't sure about reviving that thing, but yea - baseline needs an update tho
- Add ConfigurationException class in src/Exception/ConfigurationException.php - Update ServerBuilder to use the new ConfigurationException - Regenerate PHPStan baseline to account for the new exception class, reducing errors from 160+ to 124
OskarStark
force-pushed
the
exception
branch
from
7cb6388 to
03164e5
Compare
Contributor
Author
|
signed, baseline updated @chr-hertel 👍 |
chr-hertel
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.