Skip to content

Conversation

@roxblnfk
Copy link
Contributor

@roxblnfk roxblnfk commented Sep 9, 2025

Add Makefile to export-ignore in .gitattributes

This PR adds the Makefile to the export-ignore list in .gitattributes to prevent it from being included in distribution packages.

Motivation and Context

The Makefile contains development-specific commands and shortcuts that are only useful for contributors working on the codebase. End users who install this package via Composer don't need the Makefile in their vendor directory, as it's purely a development tool. Adding it to export-ignore reduces the package size and keeps the distributed package clean by excluding development-only files.

How Has This Been Tested?

This change affects only the package distribution and doesn't impact runtime functionality. The change can be verified by:

  • Creating a package archive and confirming the Makefile is excluded
  • Ensuring the Makefile continues to work normally in the development environment

Breaking Changes

No breaking changes. This only affects package distribution and has no impact on the API or functionality.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

This follows the existing pattern in .gitattributes where other development files like .php-cs-fixer.dist.php, phpstan.dist.neon, and phpunit.xml.dist are already excluded from exports. The Makefile contains common development tasks like running tests, code style fixes, and static analysis, which are only relevant for contributors.

@roxblnfk
Copy link
Contributor Author

roxblnfk commented Sep 9, 2025

Also included phpstan-baseline into ignore

@chr-hertel
Copy link
Member

Thanks @roxblnfk!

@chr-hertel chr-hertel merged commit bfc3b82 into modelcontextprotocol:main Sep 9, 2025
9 checks passed
@roxblnfk roxblnfk deleted the fix branch October 6, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants