[Server] Fix: ensure JSON-RPC error responses include message IDs #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical issue where JSON-RPC error responses were missing message IDs, causing clients to timeout waiting for responses.
Problem:
When errors occurred (method not found, invalid params, etc.), the error responses were sent without the original message ID. This caused clients to wait indefinitely for a response that would never come, leading to timeouts.
Solution:
Handler.phpto pass message IDs to all error responses using the existing Error factory methodsencodeResponse()to handle JSON encoding errors gracefully with fallback error responsesServer.phpsinceencodeResponse()no longer throws exceptions