-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Description
Initial Checks
- I confirm that I'm using the latest version of MCP Python SDK
- I confirm that I searched for my issue in https://github.com/modelcontextprotocol/python-sdk/issues before opening this issue
Description
This issue MAY be related to the following
- Possible ressource leak / race condition in streamable_http_client #1805
- Race condition in StreamableHTTP: zero-buffer memory streams cause deadlock with concurrent SSE responses #1764
- cannot get response from await session.call_tool() #262
Experiencing deadlocks on streamable_http transport. In order to reproduce the issue the following can be run.
import asyncio
import logging
import threading
import time
from fastmcp import Client, FastMCP
from fastmcp.client.transports import StreamableHttpTransport
logging.basicConfig(
level=logging.DEBUG,
format="%(asctime)s - %(name)s - %(levelname)s - %(message)s",
handlers=[logging.StreamHandler()],
)
logger = logging.getLogger(__name__)
HOST = "127.0.0.1"
PORT = 8765
SERVER_URL = f"http://{HOST}:{PORT}/mcp"
mcp = FastMCP(name="timeout issue")
SSE_TIMEOUT = 0.1
SLEEP = 60
@mcp.tool
def blocking_call() -> str:
time.sleep(SLEEP)
return "42"
def run_server():
mcp.run(transport="streamable-http", host=HOST, port=PORT)
async def test_blocking_sse():
transport = StreamableHttpTransport(SERVER_URL, sse_read_timeout=SSE_TIMEOUT)
async with Client(transport) as client:
tools = await client.list_tools()
print(f"available tools: {[t.name for t in tools]}")
result = await client.call_tool("blocking_call", {})
print(f"blocking result: {result}")
if __name__ == "__main__":
server_thread = threading.Thread(target=run_server, daemon=True)
server_thread.start()
time.sleep(2)
try:
asyncio.run(test_blocking_sse())
finally:
logger.info(f"{time.strftime('%Y-%m-%d %H:%M:%S')} [CLIENT] Shutting down...")Execution context := locally built fastmcp at this commit 790ea92
Observed Behavior: the client hangs forever after the SSE read timeout fires, looking at the logs:
- tool request is sent, server returns HTTP 200 with [Content-Type: text/event-stream]
- server starts executing the tool (blocking time.sleep(60))
- client's SSE read timeout fires (after ~5 seconds with default
httpxtimeout) - client closes the HTTP connection
- client hangs indefinitely - call_tool() never returns
- the tool eventually completes on the server side, but when the server tries to send the response back, it gets
BrokenResourceErrorbecause the HTTP connection was already closed by the client.
I know noting about nothing, so I can imagine the above example is just an issue on my side, maybe:
ssetimeout should always be greater or equal to the expected timeout of tool calls (now thatsse_read_timeoutis deprecated it'shttpx.Timeoutcounterpart should be >= tool timeout)- long running tool calls MUST send progress updates
but one thing is for sure and that is, the above configuration hangs indefenitely because the session layer never gets to know that the transport layer is dead after the SSE stream is closed
Within my ignorance of many aspects of the implementation, the missing else branch seems to be the root cause.
python-sdk/src/mcp/client/streamable_http.py
Lines 433 to 435 in a9cc822
| if last_event_id is not None: # pragma: no branch | |
| logger.info("SSE stream disconnected, reconnecting...") | |
| await self._handle_reconnection(ctx, last_event_id, retry_interval_ms) |
and the fix looks something like
if last_event_id is not None: # pragma: no branch
...
else:
error_response = JSONRPCError(...)
await ctx.read_stream_writer.send(SessionMessage(JSONRPCMessage(root=error_response)))consequently raising McpError
Example Code
Python & MCP Python SDK
Execution context for ease of implementation
- `mcp==1.24.0`
- example codebase run against locally built `fastmcp` at [790ea92](https://github.com/jlowin/fastmcp/tree/790ea92eb59256da68c83097321ebde8f8819bcf) --> 1.24.0
- Python: `python-3.12.7-macos-aarch64-none/bin/python3.12`