fix: use proper dependency resolution in CI #1507
Merged
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixweinberger
force-pushed
the
fweinberger/fix-pipeline
branch
5 times, most recently
from
59642be to
63363bf
Compare
felixweinberger
commented
Oct 23, 2025
| run: uv run --frozen --no-sync pytest | ||
| run: uv run ${{ matrix.dep-resolution.install-flags }} --no-sync pytest | ||
| env: | ||
| UV_RESOLUTION: ${{ matrix.dep-resolution.name == 'lowest-direct' && 'lowest-direct' || 'highest' }} |
There was a problem hiding this comment.
This is needed to ensure subprocesses use the same resolution strategy when they run uv sync rather than overwrite the venv as in @maxisbey's comment: #1325 (comment)
felixweinberger
force-pushed
the
fweinberger/fix-pipeline
branch
from
9c7c2a4 to
fc7836d
Compare
- Restructure dep-resolution matrix with name and install-flags - Use uv sync with appropriate flags for each resolution strategy - Set UV_RESOLUTION env var to ensure test subprocesses use correct strategy This fixes the issue where tests spawning uv run subprocesses were re-resolving dependencies using the lockfile instead of respecting the lowest-direct resolution strategy.
felixweinberger
force-pushed
the
fweinberger/fix-pipeline
branch
from
fc7836d to
0a22bb6
Compare
Kludex
previously approved these changes
Oct 23, 2025
felixweinberger
force-pushed
the
fweinberger/fix-pipeline
branch
from
8945b6c to
48280fe
Compare
felixweinberger
force-pushed
the
fweinberger/fix-pipeline
branch
from
48280fe to
aed48b3
Compare
|
Are my reviews being dismissed on any code change or on force-pushes? 🤔 |
maxisbey
approved these changes
Oct 23, 2025
Should be on any code change, see: https://github.com/modelcontextprotocol/python-sdk/rules/3187917 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The CI was incorrectly using --frozen with both resolution strategies.
The --frozen flag should only be used with the highest resolution
strategy (which uses the lockfile), while lowest-direct resolution
needs to resolve dependencies dynamically using --resolution lowest-direct.
This change restructures the matrix to properly pass the correct flags
for each resolution strategy, fixing the CI pipeline.
Github-Issue: #1325
How Has This Been Tested?
CI
Breaking Changes
No
Types of changes
Checklist
Additional context