Skip to content

fix: use proper dependency resolution in CI #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

fix: use proper dependency resolution in CI #1507

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a22bb6
fix: use proper dependency resolution in CI
felixweinberger Oct 23, 2025
aed48b3
fix: update test job names to match branch protection rules
felixweinberger Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/shared.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,18 @@ jobs:
SKIP: no-commit-to-branch

test:
name: test (${{ matrix.python-version }}, ${{ matrix.dep-resolution.name }}, ${{ matrix.os }})
runs-on: ${{ matrix.os }}
timeout-minutes: 10
continue-on-error: true
strategy:
matrix:
python-version: ["3.10", "3.11", "3.12", "3.13"]
dep-resolution: ["lowest-direct", "highest"]
dep-resolution:
- name: lowest-direct
install-flags: "--resolution lowest-direct"
- name: highest
install-flags: "--frozen"
os: [ubuntu-latest, windows-latest]

steps:
Expand All @@ -49,10 +54,12 @@ jobs:
version: 0.9.5

- name: Install the project
run: uv sync --frozen --all-extras --python ${{ matrix.python-version }} --resolution ${{ matrix.dep-resolution }}
run: uv sync ${{ matrix.dep-resolution.install-flags }} --all-extras --python ${{ matrix.python-version }}

- name: Run pytest
run: uv run --frozen --no-sync pytest
run: uv run ${{ matrix.dep-resolution.install-flags }} --no-sync pytest
env:
UV_RESOLUTION: ${{ matrix.dep-resolution.name == 'lowest-direct' && 'lowest-direct' || 'highest' }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to ensure subprocesses use the same resolution strategy when they run uv sync rather than overwrite the venv as in @maxisbey's comment: #1325 (comment)


readme-snippets:
runs-on: ubuntu-latest
Expand Down
Loading