Skip empty SSE data to avoid parsing errors #1753
Merged
+74
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
pinbraerts
reviewed
Dec 9, 2025
The original test didn't actually exercise the `if not sse.data: continue` code path. This rewrite: - Mocks the SSE event stream to include an empty "message" event - Uses httpx_sse.ServerSentEvent for accurate event simulation - Uses proper type serialization instead of hardcoded JSON strings - Validates that the client skips empty data and receives the real response
maxisbey
approved these changes
Dec 9, 2025
maxisbey
added
bug
Contributor
|
This PR is included in version v1.23.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context