Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mcp/server/mcpserver/utilities/func_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def convert_result(self, result: Any) -> Any:
the structured output.
"""
if isinstance(result, CallToolResult):
if self.output_schema is not None:
if self.output_schema is not None and not result.is_error:
assert self.output_model is not None, "Output model must be set if output schema is defined"
self.output_model.model_validate(result.structured_content)
return result
Expand Down
18 changes: 18 additions & 0 deletions tests/server/mcpserver/test_func_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,24 @@ def func_returning_annotated_tool_call_result() -> Annotated[CallToolResult, Per
meta.convert_result(func_returning_annotated_tool_call_result())


def test_tool_call_result_with_is_error_skips_output_schema_validation():
"""Test that convert_result skips outputSchema validation when is_error=True."""

class PersonClass(BaseModel):
name: str

def func_with_error() -> Annotated[CallToolResult, PersonClass]:
return CallToolResult(content=[], is_error=True)

meta = func_metadata(func_with_error)
assert meta.output_schema is not None

result = meta.convert_result(func_with_error())

assert isinstance(result, CallToolResult)
assert result.is_error is True


def test_tool_call_result_in_optional_is_rejected():
"""Test that Optional[CallToolResult] raises InvalidSignature"""

Expand Down
Loading