fix: strip trailing slash from resource URL in get_resource_url()#2580
Open
siddhirajkatkar wants to merge 1 commit into
Open
fix: strip trailing slash from resource URL in get_resource_url()#2580siddhirajkatkar wants to merge 1 commit into
siddhirajkatkar wants to merge 1 commit into
Conversation
Pydantic v2 AnyHttpUrl adds a trailing slash to bare-domain URLs when str() is called, causing audience mismatch with Entra ID v2.0 which registers the resource without a trailing slash. Fixes modelcontextprotocol#2578
siddhirajkatkar
force-pushed
the
fix/oauth-resource-trailing-slash
branch
from
795bcb8 to
02da247
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2578
Problem
Pydantic v2
AnyHttpUrladds a trailing slash to bare-domain URLswhen
str()is called:This causes an audience mismatch with Microsoft Entra ID v2.0, which
registers the resource as
https://mcp-server.example.com(no slash),resulting in AADSTS9010010 errors after token refresh.
Fix
Strip the trailing slash in
get_resource_url():Files Changed
src/mcp/client/auth/oauth2.pyline 154