fix: preserve optional string JSON arguments#2620
Open
pragnyanramtha wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
str | Nonelist[str] | NoneFixes #1873.
Context
FastMCP already preserves JSON-looking values for plain
strarguments, butstr | Nonestill went throughjson.loads(...)during argument pre-parsing. That means an optional string receiving a JSON object or array string was converted to adict/listbefore Pydantic validation, then rejected or corrupted instead of reaching the tool as the annotated string value.This keeps structured annotations parseable while treating unions of simple scalar types like simple scalar fields.
Validation
uv run --frozen pytest tests/server/mcpserver/test_func_metadata.py-> 36 passeduv run --frozen pytest tests/server/mcpserver/test_tool_manager.py-> 50 passeduv run --frozen ruff check src/mcp/server/mcpserver/utilities/func_metadata.py tests/server/mcpserver/test_func_metadata.py-> passeduv run --frozen pyright src/mcp/server/mcpserver/utilities/func_metadata.py tests/server/mcpserver/test_func_metadata.py-> 0 errorsgit diff --check-> passed