Fix completed request cancellation cleanup#2624
Open
FU-max-boop wants to merge 1 commit into
Open
Conversation
FU-max-boop
force-pushed
the
fix/request-responder-cancel-leak
branch
from
5db90d2 to
bb76886
Compare
Code ReviewPR: Fix completed request cancellation cleanup by @FU-max-boop
Wallet: Code review for MCP Python SDK |
Code ReviewPR: Fix completed request cancellation cleanup by @FU-max-boop
Wallet: Reviewing under MCP ecosystem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CancelScope.__exit__only afterRequestResponderhas already completed and sent a responseFixes #2610.
Validation
uv run pytest tests/shared/test_session.py::test_request_cancellation tests/shared/test_session.py::test_completed_request_responder_suppresses_cancel_scope_exit tests/shared/test_session.py::test_incomplete_request_responder_propagates_cancel_scope_exit tests/server/test_cancel_handling.py -quv run ruff format --check src/mcp/shared/session.py tests/shared/test_session.pyuv run ruff check src/mcp/shared/session.py tests/shared/test_session.pyuv run pyright src/mcp/shared/session.py tests/shared/test_session.pygit diff --check