fix: add 'invalid_target' to AuthorizationErrorCode (RFC 8707)#2642
Open
siddhirajkatkar wants to merge 1 commit into
Open
fix: add 'invalid_target' to AuthorizationErrorCode (RFC 8707)#2642siddhirajkatkar wants to merge 1 commit into
siddhirajkatkar wants to merge 1 commit into
Conversation
RFC 8707 §2 defines 'invalid_target' as the error code for resource indicator mismatches. Without it, AuthorizeError(error='invalid_target') triggers a pydantic ValidationError instead of an OAuth-compliant response. Fixes modelcontextprotocol#2641
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2641
RFC 8707 §2 defines
invalid_targetas the error code for resourceindicator mismatches. Without it,
AuthorizeError(error="invalid_target")triggers a pydantic
ValidationErrorinstead of an OAuth-complianterror response, masking the real cause with a generic
server_error.Change
Added
"invalid_target"toAuthorizationErrorCodeinsrc/mcp/server/auth/provider.py:No other changes required —
AuthorizationErrorResponseandAuthorizeErroralready accept the Literal type by reference.This also removes the
# type: ignoreannotations in FastMCP'sOAuthProxythat worked around this gap.