refactor: remove redundant blank identifier for argIndex in ListServers#1240
Closed
mesutoezdil wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
Conversation
argIndex is already used in fmt.Sprintf on line 215 so the blank assignment on the line before was not needed.
Member
|
Thanks for the cleanup! Since #1241 already includes this same change, I'll close this one as superseded. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blank assignment
_ = argIndexon line 201 ofinternal/database/postgres.gowas not needed.argIndexis already read byfmt.Sprintftwo lines below when building theLIMITclause of the query.